LADX: more marin joke text #3966
Open
+470
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates of Splash text 24-09-18 * Re-Adds '
|
You can submit your own jokes here: We will keep this going for a bit and then close it. |
* Adds all community suggestions up until 20/09/2024 * cutting deathlink jokes --------- Co-authored-by: Alex Nordstrom <[email protected]>
SushiKishi
approved these changes
Oct 27, 2024
Exempt-Medic
added
is: enhancement
palex00
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
This PR was tested as part of a Beta apworld that was used in three dedicated Test Asyncs, as well as dozen of normal Syncs. I have also personally run 200 test generations which succeeded.
We have also done polling on what users want, etc. which can be found here
The new feature has worked as expected and other stuff does not seem impacted.
We found one bug where the text was too long but the 2nd largest text passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Pulls in the upstream pool of Marin joke text, with updates by @palex00 , and more Archipelago community submissions pending.
How was this tested?
It generates.